OAK-11367: Remove usage of Guava Chars.contains() #1964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit-Check ✔️ |
|
rishabhdaim
reviewed
Jan 9, 2025
| } | ||
| rewritten.append(c); | ||
| } else if (Chars.contains(QUERY_OPERATORS, c)) { | ||
| } else if (QUERY_OPERATORS.indexOf(c) >= 0) { |
Contributor
There was a problem hiding this comment.
I would convert QUERY_OPERATORS to Set<Character> and then use Set.contains.
Contributor
There was a problem hiding this comment.
That would be more expensive. A Set<Character> requires boxing the elements. And a call to Set.contains will box the argument and calculate an hash. A linear search on a character array, as String.indexOf does, uses much less logic per call and will certainly be faster for an array of just 6 elements (all contiguous in memory).
rishabhdaim
approved these changes
Jan 9, 2025
andreeastroe96
pushed a commit
to andreeastroe96/jackrabbit-oak
that referenced
this pull request
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.