OAK-11491 clear system property in tearDown method#2086
Merged
smiroslav merged 3 commits intoapache:trunkfrom Feb 17, 2025
Merged
OAK-11491 clear system property in tearDown method#2086smiroslav merged 3 commits intoapache:trunkfrom
smiroslav merged 3 commits intoapache:trunkfrom
Conversation
| READ_WRITE.setAddPermission(true); | ||
| System.setProperty("segment.azure.v12.enabled", "true"); | ||
|
|
||
| System.setProperty(AzureSegmentStoreService.SEGMENT_AZURE_V_12_ENABLED, "true"); |
Member
There was a problem hiding this comment.
Suggested change
| System.setProperty(AzureSegmentStoreService.SEGMENT_AZURE_V_12_ENABLED, "true"); | |
| oldPropertyValue = System.getProperty(AzureSegmentStoreService.SEGMENT_AZURE_V_12_ENABLED); | |
| System.setProperty(AzureSegmentStoreService.SEGMENT_AZURE_V_12_ENABLED, "true"); |
|
|
||
| @AfterClass | ||
| public static void tearDown() { | ||
| System.clearProperty(AzureSegmentStoreService.SEGMENT_AZURE_V_12_ENABLED); |
Member
There was a problem hiding this comment.
Suggested change
| System.clearProperty(AzureSegmentStoreService.SEGMENT_AZURE_V_12_ENABLED); | |
| System.setProperty(AzureSegmentStoreService.SEGMENT_AZURE_V_12_ENABLED, oldPropertyValue); |
thomasmueller
approved these changes
Feb 17, 2025
Contributor
Author
|
The build failed for oak-store-document Since oak-store-document is unaffected by the changes made here, I will merge PR. |
andreeastroe96
pushed a commit
to andreeastroe96/jackrabbit-oak
that referenced
this pull request
Feb 25, 2025
* OAK-11491 clear system property in tearDown method * OAK-11491 remember the old value of the system property * OAK-11491 rename property --------- Co-authored-by: Miroslav Smiljanic <miroslav@apache.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/OAK-11491