OAK-9200#249
Closed
Vinod-holani wants to merge 5 commits into
Closed
Conversation
…rationImpl causing performance issues
Contributor
|
@Vinod-holani , had a quick look at the change, because it affects a class in the security area. i cannot comment on the usage of blobaccessprovider in the userconfiguration (not really familiar with the blob-handling in oak). but i have a general comment: i would very much appreciate, if your patch would come with tests illustrating the problem you are aiming to fix. it should fail without the patch and obviously pass with the patch applied. |
one more assertion scenario
were dependent on whiteboard utils
Contributor
|
Changes have been merged to SVN. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing Oak BlobAccessProvider reference initialization in UserConfigurationImpl causing performance issues