OAK-12119 : offline compaction does not persist compacted head into gc.log

[rishabhdaim]

Summary

• Offline compaction (compactFull() + cleanup() as separate calls, as used by oak-run compact) failed to write a gc.log entry because the CompactionResult from compactFull() was discarded before cleanup() ran
• Fix stores the CompactionResult in GarbageCollector after compactFull()/compactTail() and passes it directly to the 2-arg cleanup(Context, CompactionResult) overload
• Added cleanup(Context, CompactionResult) to the GarbageCollectionStrategy interface so GarbageCollector can call it through the interface type

Changes

• GarbageCollectionStrategy.java — add cleanup(Context, CompactionResult) to the interface
• GarbageCollector.java — store lastCompactionResult after compaction; pass it to cleanup, falling back to a skipped result when absent
• SynchronizedGarbageCollectionStrategy.java — implement the new 2-arg cleanup overload
• DefaultGarbageCollectionStrategyTest.java — update test setup for the fix
• GarbageCollectorOfflineCompactionTest.java — new integration tests at GarbageCollector level using ArgumentCaptor to verify gc.log persistence
• OfflineCompactionGcLogTest.java — end-to-end regression tests against a real FileStore

Test Plan

• GarbageCollectorOfflineCompactionTest — verifies correct cleanup overload is called with the right CompactionResult
• OfflineCompactionGcLogTest — verifies gc.log is written after offline compaction (regression tests, fail on unfixed code)
• DefaultGarbageCollectionStrategyTest — existing tests still pass

Links

• JIRA: https://issues.apache.org/jira/browse/OAK-12119

[rishabhdaim]

@lweitzendorf could you please review the changes ?

[reschke]

Lacking detailed knowledge of publish persistence, I can only say: it has tests that prove the bug and the fix. Good.

FWIW, at least one of the Sonar warnings might be of interest.

[rishabhdaim]

Lacking detailed knowledge of publish persistence, I can only say: it has tests that prove the bug and the fix. Good.

FWIW, at least one of the Sonar warnings might be of interest.

Addressed in 3635689

[lweitzendorf]

Looks good, thanks for the fix!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud