Skip to content

OAK-11300 : remove unused common.hash export from oak-shaded-guava#2803

Merged
rishabhdaim merged 1 commit intotrunkfrom
OAK-11300
Mar 19, 2026
Merged

OAK-11300 : remove unused common.hash export from oak-shaded-guava#2803
rishabhdaim merged 1 commit intotrunkfrom
OAK-11300

Conversation

@rishabhdaim
Copy link
Contributor

Summary

  • Removes common.hash from Export-Package in oak-shaded-guava/pom.xml — no class in the codebase imports org.apache.jackrabbit.guava.common.hash
  • Excludes com/google/common/hash/** from the shade plugin filter, consistent with how common.graph was removed in the previous commit

Changes

  • oak-shaded-guava/pom.xml: add hash to shade excludes, remove from Export-Package

Test Plan

  • mvn apache-rat:check -pl oak-shaded-guava passes
  • mvn clean install -pl oak-shaded-guava -DskipTests passes

Links

@rishabhdaim rishabhdaim self-assigned this Mar 18, 2026
@rishabhdaim rishabhdaim requested a review from reschke March 18, 2026 16:18
@sonarqubecloud
Copy link

@rishabhdaim rishabhdaim merged commit e94ee9f into trunk Mar 19, 2026
3 checks passed
@rishabhdaim rishabhdaim deleted the OAK-11300 branch March 19, 2026 15:26
@reschke reschke restored the OAK-11300 branch March 22, 2026 14:28
reschke added a commit that referenced this pull request Mar 22, 2026
…guava (#2803)"

This reverts commit e94ee9f.

Reverted due to downstream issues, to be investigated,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants