OAK-12143 - Fix AsyncLaneSwitcher not switching lanes when async-previous pre-set#2812
Open
antonhosgood wants to merge 1 commit intoapache:OAK-12143from
Open
OAK-12143 - Fix AsyncLaneSwitcher not switching lanes when async-previous pre-set#2812antonhosgood wants to merge 1 commit intoapache:OAK-12143from
antonhosgood wants to merge 1 commit intoapache:OAK-12143from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
switchLanereturns early wheneverasync-previousis set, assuming the lane has already been switched. However,async-previouscan legitimately appear in user-provided index definitions (e.g. copied from a running system), causing the switch to be skipped incorrectly and the index to be silently dropped from reindexing.The fix tightens the early-return check: only skip if
async-previousis present andasyncalready equals the target lane. Ifasync-previousis present butasyncdoes not match the target lane, the property is treated as stale, discarded, and the switch proceeds normally.