OAK-12181 - add metric when repository lock could not be renewed#2850
Merged
Conversation
|
jsedding
approved these changes
Apr 16, 2026
Contributor
jsedding
left a comment
jsedding
left a comment
There was a problem hiding this comment.
Looks good @smiroslav. Just one question/suggestion. Up to you if it makes sense or not.
|
|
||
| private static void attachRemoteStoreMonitor(RemoteStoreMonitor remoteStoreMonitor) { | ||
| private void attachRemoteStoreMonitor(RemoteStoreMonitor remoteStoreMonitor) { | ||
| this.remoteStoreMonitor.set(remoteStoreMonitor); |
Contributor
There was a problem hiding this comment.
Would it make sense to only allow RemoteStoreMonitor to be set once?
Suggested change
| this.remoteStoreMonitor.set(remoteStoreMonitor); | |
| this.remoteStoreMonitor.getAndUpdate(oldValue -> { | |
| if (oldValue == null) { | |
| return remoteStoreMonitor; | |
| } | |
| throw new IllegalStateException("attachRemoteStoreMonitor may only be called once"); | |
| }); |
Contributor
Author
There was a problem hiding this comment.
Thanks @jsedding for the suggestion.
I am thinking since the method is public, theoretically it could be called more than once for the same persistence, not that I see how it would make sense. I am a bit reluctant to add that set-once guard since we do not document this behaviour in the interface.
| } | ||
|
|
||
| private void attachRemoteStoreMonitor(RemoteStoreMonitor remoteStoreMonitor) { | ||
| this.remoteStoreMonitor.set(remoteStoreMonitor); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/OAK-12181