Skip to content

OAK-12201 : added missing IterableUtils import#2886

Merged
rishabhdaim merged 1 commit into
trunkfrom
OAK-12201
May 6, 2026
Merged

OAK-12201 : added missing IterableUtils import#2886
rishabhdaim merged 1 commit into
trunkfrom
OAK-12201

Conversation

@rishabhdaim
Copy link
Copy Markdown
Contributor

No description provided.

@rishabhdaim rishabhdaim requested a review from reschke May 5, 2026 05:49
@rishabhdaim rishabhdaim self-assigned this May 5, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 5, 2026

Copy link
Copy Markdown
Contributor

@reschke reschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can it be missing if the source compiled before.....?

@reschke reschke self-requested a review May 6, 2026 07:41
@rishabhdaim
Copy link
Copy Markdown
Contributor Author

From Codex:

Strictly: yes, it can compile because CdCommand is Groovy, not Java, and it is not statically compiled. Groovy can compile an unresolved IterableUtils reference as a dynamic property/expression.

Practically: no, you should not remove it. The source uses IterableUtils.limit(...) at CdCommand.groovy (line 42). Without the import at CdCommand.groovy (line 23), it would likely fail at runtime with MissingPropertyException: No such property: IterableUtils.

I also checked the generated Java stub: it has empty method bodies, so its lack of IterableUtils does not prove the real Groovy source is safe without the import. Current oak-run compile succeeds with the import.

@rishabhdaim rishabhdaim merged commit 05c80b5 into trunk May 6, 2026
4 checks passed
@rishabhdaim rishabhdaim deleted the OAK-12201 branch May 6, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants