Conversation
…any many many tests
Commit-Check ❌ |
…TRLs and scheme case
…plitting only at first colon
…roper base64 decoding
mbaedke
requested changes
Jun 29, 2026
rishabhdaim
requested changes
Jun 30, 2026
Contributor
There was a problem hiding this comment.
AI Review:
The production logic is correct — indexOf(':') properly handles colons in passwords, case-insensitive scheme match is right, and the AIOOBE→LoginException shift is the intended fix. Three test issues before merge.
nit: AuthorizationField.java:33 — new public method, AGENTS.md requires @NotNull/@Nullable annotations:
public static @NotNull SimpleCredentials valueOf(@NotNull Enumeration<String> values) throws LoginException
rishabhdaim
reviewed
Jun 30, 2026
Comment on lines
54
to
55
rishabhdaim
reviewed
Jun 30, 2026
…ationFieldTest.java Co-authored-by: Rishabh Kumar <rishabhdaim1991@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



…any many many tests.
EDIT: hint: this is a demo project. The PR fixes a ton of issues. The fixes have test coverage. There's a point where nitpicking on the test cases becomes a waste of time. Please only report major problems.