OAK-9482: upgrade httpclient to 4.5.13 #310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
averma21
approved these changes
Jul 2, 2021
reschke
requested changes
Jul 2, 2021
Contributor
reschke
left a comment
reschke
left a comment
There was a problem hiding this comment.
You should update httpcore as well.
Contributor
Author
|
@reschke I did not because httpclient 4.5.13 is compiled/tested/released with httpcore 4.4.13 (https://github.com/apache/httpcomponents-client/blob/rel/v4.5.13/pom.xml#L69). The latest httpcore will be used in the next release of httpclient. |
Member
|
Test |
thomasmueller
approved these changes
Jul 6, 2021
Contributor
Author
|
@reschke correct, the update to v 4.5.13 is to avoid the vulnerability you mentioned (https://issues.apache.org/jira/browse/OAK-9482) |
Contributor
|
Yep, I misread the CVE. Anyway; I understand the desire to use this combination, but given the fact that there are bugfixes in httpcore I really do not understand why we wouldn't use it, There's a reason why that release was made. |
reschke
approved these changes
Jul 6, 2021
Joscorbe
pushed a commit
to Joscorbe/jackrabbit-oak
that referenced
this pull request
Sep 3, 2021
* OAK-9482: upgrade httpclient to 4.5.13 * OAK-9482: align httpmime to v 4.5.13 * OAK-9482: upgrade httpcore to 4.4.14
reschke
pushed a commit
that referenced
this pull request
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.