OAK-9671 Increase dynamicBoost and dynamicBoostLite full-text test co…#469
Merged
fabriziofortino merged 7 commits intoapache:trunkfrom Feb 4, 2022
Merged
OAK-9671 Increase dynamicBoost and dynamicBoostLite full-text test co…#469fabriziofortino merged 7 commits intoapache:trunkfrom
fabriziofortino merged 7 commits intoapache:trunkfrom
Conversation
fabriziofortino
approved these changes
Jan 26, 2022
Contributor
fabriziofortino
left a comment
fabriziofortino
left a comment
There was a problem hiding this comment.
Good work. I would remove the unit tests for the dynamicboost scenario we cannot support.
.../test/java/org/apache/jackrabbit/oak/plugins/index/lucene/dynamicBoost/DynamicBoostTest.java
Outdated
Show resolved
Hide resolved
.../test/java/org/apache/jackrabbit/oak/plugins/index/lucene/dynamicBoost/DynamicBoostTest.java
Outdated
Show resolved
Hide resolved
.../test/java/org/apache/jackrabbit/oak/plugins/index/lucene/dynamicBoost/DynamicBoostTest.java
Outdated
Show resolved
Hide resolved
.../test/java/org/apache/jackrabbit/oak/plugins/index/lucene/dynamicBoost/DynamicBoostTest.java
Outdated
Show resolved
Hide resolved
.../test/java/org/apache/jackrabbit/oak/plugins/index/lucene/dynamicBoost/DynamicBoostTest.java
Outdated
Show resolved
Hide resolved
…verage: remove some unsupported query test
…verage: fix case insensitive query for dynamicBoostLite and adding tests
FrancoisZhang
commented
Jan 31, 2022
...lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/LucenePropertyIndex.java
Outdated
Show resolved
Hide resolved
…verage: fix dynamic boost lite query with space issue, explained as OR
…verage: fix DynamicBoostLite to make it fully support the lucene fulltext query syntax
fabriziofortino
approved these changes
Feb 3, 2022
…verage: clean up tests
Contributor
|
Thanks @FrancoisZhang 🍟 🍺 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…verage