OAK-9726 Improve index purge old version commands logs#520
Merged
thomasmueller merged 3 commits intoapache:trunkfrom Mar 17, 2022
Merged
OAK-9726 Improve index purge old version commands logs#520thomasmueller merged 3 commits intoapache:trunkfrom
thomasmueller merged 3 commits intoapache:trunkfrom
Conversation
…lemented in oak-run: adjust APIs and adding logs
Contributor
|
Please refer to OAK Jira tickets in commit messages and PRs. |
thomasmueller
requested changes
Mar 16, 2022
oak-run/src/main/java/org/apache/jackrabbit/oak/indexversion/PurgeOldIndexVersion.java
Outdated
Show resolved
Hide resolved
oak-run/src/main/java/org/apache/jackrabbit/oak/indexversion/PurgeOldIndexVersion.java
Outdated
Show resolved
Hide resolved
oak-run/src/main/java/org/apache/jackrabbit/oak/indexversion/PurgeOldIndexVersion.java
Outdated
Show resolved
Hide resolved
…lemented in oak-run: adjust log messages etc. per code review
FrancoisZhang
changed the title
Contributor
Author
|
@reschke sorry for that, just created an OAK ticket and fix the message in PR @thomasmueller I have refined the commit over your code review, thanks! |
…plemented in oak-run: adjust log messages
thomasmueller
approved these changes
Mar 17, 2022
|
|
||
| private long threshold; | ||
| private List<String> indexPaths; | ||
| private long DEFAULT_PURGE_THRESHOLD = TimeUnit.DAYS.toMillis(5); // 5 days in millis |
Contributor
There was a problem hiding this comment.
this should be final
Contributor
Author
There was a problem hiding this comment.
@fabriziofortino true, i's a legacy I didn't notice that. I will refine it together in next PR. seems need more logging here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.