OAK-9792 - The maximum number of search results per page is increased…#586
Closed
AngelaFabregues wants to merge 2 commits intoapache:trunkfrom
Closed
OAK-9792 - The maximum number of search results per page is increased…#586AngelaFabregues wants to merge 2 commits intoapache:trunkfrom
AngelaFabregues wants to merge 2 commits intoapache:trunkfrom
Conversation
… to meet the AEM query max
reschke
requested changes
Jun 2, 2022
...ic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticIndexDefinition.java
Outdated
Show resolved
Hide resolved
…ble and defaults to the Elasticsearch default one
Contributor
|
We should not increase this value. 10k results per page is already a quite large value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… to meet the AEM query max.
This PR is ready and has been tested in local. However, we should wait or @fabriziofortino approval before merging.