OAK-9814: Improvements in NodeState/VersionCopier for visibility of p… #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aths added and preserve sub-paths - Added an optional consumer to be notified of any added paths - Create a new preserveOnTarget which does not delete any sub-paths on target
Contributor
Author
|
test failure in org.apache.jackrabbit.j2ee.TomcatIT due to timeouts and doesn't look related to the changes here
|
trekawek
approved these changes
Jun 28, 2022
Contributor
trekawek
left a comment
trekawek
left a comment
There was a problem hiding this comment.
LGTM. Let's just make it clear what the new consumer accepts.
| boolean referenceableFrozenNodes) { | ||
| boolean referenceableFrozenNodes, | ||
| boolean preserveOnTarget, | ||
| Consumer<String> consumer) { |
Contributor
There was a problem hiding this comment.
Let's call is newNodesConsumer or something like that.
…aths added and preserve sub-paths Review changes - Rename consumer variable to make clear intention of consuming added paths only
rishabhdaim
pushed a commit
to rishabhdaim/jackrabbit-oak
that referenced
this pull request
Jul 4, 2022
apache#603) - Added an optional consumer to be notified of any added paths - Create a new preserveOnTarget which does not delete any sub-paths on target - Rename consumer variable to make clear intention of consuming added paths only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…aths added and preserve sub-paths