OAK-9840: wait for all required MountInfoConfigs#623
Merged
Conversation
also consider later configs by making the reference greedy
Contributor
|
Thanks for catching this. |
jelmini
approved these changes
Jul 18, 2022
kwin
commented
Jul 18, 2022
| } | ||
|
|
||
| @Reference(cardinality = ReferenceCardinality.MULTIPLE) | ||
| @Reference(cardinality = ReferenceCardinality.MULTIPLE, policyOption = ReferencePolicyOption.GREEDY) |
Member
Author
There was a problem hiding this comment.
Probably this was thought to be dynamic (not static) as it is threadsafe (CopyOnWriteArrayList) and leads to less reactivation of this service. Also dynamic makes the greedy part obsolete: https://docs.osgi.org/specification/osgi.cmpn/8.0.0/service.component.html#d0e30480
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
also consider later configs by making the reference greedy