OAK-9924: elastic mbean reports both primary and store size#693
Merged
fabriziofortino merged 2 commits intoapache:trunkfrom Sep 9, 2022
Merged
OAK-9924: elastic mbean reports both primary and store size#693fabriziofortino merged 2 commits intoapache:trunkfrom
fabriziofortino merged 2 commits intoapache:trunkfrom
Conversation
nit0906
reviewed
Sep 8, 2022
...ic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/ElasticIndexStatistics.java
Outdated
Show resolved
Hide resolved
nit0906
approved these changes
Sep 8, 2022
fabriziofortino
changed the title
thomasmueller
approved these changes
Sep 9, 2022
tihom88
approved these changes
Sep 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Elastic MBean
indexSizereturned the total store size (which includes replicas). This was a bit confusing since, depending on the replica factor, this value could be way bigger than the sole primary shards' size.indexSizenow returns the primary shards' size, and a new columnindexSizeWithReplicasreturns the total size including replicas. Also aligned metrics to rerun both values.