OAK-9951 - Improve support for running unit tests with Elasticsearch 8#713
Merged
fabriziofortino merged 2 commits intoapache:trunkfrom Sep 21, 2022
nfsantos:OAK-9951
Merged
OAK-9951 - Improve support for running unit tests with Elasticsearch 8#713fabriziofortino merged 2 commits intoapache:trunkfrom nfsantos:OAK-9951
fabriziofortino merged 2 commits intoapache:trunkfrom
nfsantos:OAK-9951
Conversation
…it is enough to pass the property -DelasticDockerImageVersion=[8.3.3|8.4.4] to the Maven build. In more detail: the tests need to install the Elastiknn plugin in the test Elasticsearch container, with a matching version. The plugin is downloaded from GitHub at the start of the tests. To validate that the right plugin was downloaded, the test infrastructure compares the digest of the file with the plugin with an expected digest. This PR adds the digests for versions 8.3.3 and 8.4.1 of the Elastiknn plugin.
joerghoh
approved these changes
Sep 21, 2022
Contributor
|
Where did you take these digests from? |
Contributor
Author
I take them from a run of the unit tests. I run the tests with a version of the Elastiknn for which I don't have the digest and copy the digest from the error message that shows that the digest did not match with a dummy digest. This is just to make sure the released version of the plugin does not change. |
fabriziofortino
approved these changes
Sep 21, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add OOTB support for testing with Elasticsearch 8.3.3, 8.4.1 and 8.4.2. Now it is enough to pass the property -DelasticDockerImageVersion=[8.3.3|8.4.1|8.4.2] to the Maven build.
In more detail: the tests need to install the Elastiknn plugin in the test Elasticsearch container, with a matching version. The plugin is downloaded from GitHub at the start of the tests. To validate that the right plugin was downloaded, the test infrastructure compares the digest of the file with the plugin with an expected digest. This PR adds the digests for versions 8.3.3, 8.4.1 and 8.4.2 of the Elastiknn plugin.