Merged
Conversation
mbaechler
approved these changes
Jul 5, 2019
Member
mbaechler
left a comment
mbaechler
left a comment
There was a problem hiding this comment.
Looks good to me (and tests are green when run locally)
Arsnael
approved these changes
Jul 5, 2019
chibenwa
approved these changes
Jul 5, 2019
Member
|
Thank you for you contribution @Weiling-Liao |
remk
reviewed
Jul 5, 2019
| public void testInvalidFWSSyntax() { | ||
| try { | ||
| new TagValue("p=test \r\n\r\n "); | ||
| new TagValue("p=test \r\n\r\n"); |
There was a problem hiding this comment.
I'm not familiar with FWS. But does the assertion still make sense once the whitespace after the CRLF is removed ?
Author
There was a problem hiding this comment.
According to https://tools.ietf.org/html/rfc6376#section-2.8 , CRLF followed by at least one whitespace, so this new version without at least one whitespace after CRLF will be wrong FWS.
Author
There was a problem hiding this comment.
And this is a invalid FWS test. Plz let me know if there is any concern. Thanks
agrinchenko
pushed a commit
to agrinchenko/james-jdkim
that referenced
this pull request
Mar 28, 2026
Fix FWS is not trimmed correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.