JAMES-3775 Write webadmin route to create feeding ham messages task#1098
Merged
chibenwa merged 2 commits intoapache:masterfrom Aug 20, 2022
Merged
JAMES-3775 Write webadmin route to create feeding ham messages task#1098chibenwa merged 2 commits intoapache:masterfrom
chibenwa merged 2 commits intoapache:masterfrom
Conversation
Arsnael
approved these changes
Aug 1, 2022
chibenwa
reviewed
Aug 1, 2022
third-party/rspamd/src/main/java/org/apache/james/rspamd/task/FeedHamToRSpamDTask.java
Outdated
Show resolved
Hide resolved
chibenwa
reviewed
Aug 1, 2022
third-party/rspamd/src/main/java/org/apache/james/rspamd/task/FeedHamToRSpamDTask.java
Outdated
Show resolved
Hide resolved
chibenwa
reviewed
Aug 1, 2022
third-party/rspamd/src/main/java/org/apache/james/rspamd/task/FeedHamToRSpamDTask.java
Outdated
Show resolved
Hide resolved
40523e3 to
d7ee25c
Compare
Member
Author
|
2 latest fixup commits address comments of this PR and similar ones in Spam PR. The rest is basically the same. |
d7ee25c to
75d9c84
Compare
vttranlina
pushed a commit
to vttranlina/james-project
that referenced
this pull request
Aug 10, 2022
vttranlina
pushed a commit
to vttranlina/james-project
that referenced
this pull request
Aug 10, 2022
Contributor
|
The ci fail is not related to this pr |
Contributor
|
Can you fix the typo "RSpamD" to "Rspamd"? |
Member
Author
Me what I don't like is that instead of 1 PR doing 1 job that fixes the typo, now what you suggest is others n PRs doing both their job plus the fix the typo stuff. Me I would prefer the typo PR to do its clean job eventually. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.