Skip to content

JAMES-3775 Write webadmin route to create feeding ham messages task#1098

Merged
chibenwa merged 2 commits intoapache:masterfrom
quantranhong1999:feed-ham
Aug 20, 2022
Merged

JAMES-3775 Write webadmin route to create feeding ham messages task#1098
chibenwa merged 2 commits intoapache:masterfrom
quantranhong1999:feed-ham

Conversation

@quantranhong1999
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Contributor

@chibenwa chibenwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit for period also.

@quantranhong1999 quantranhong1999 force-pushed the feed-ham branch 2 times, most recently from 40523e3 to d7ee25c Compare August 2, 2022 08:57
@quantranhong1999
Copy link
Copy Markdown
Member Author

2 latest fixup commits address comments of this PR and similar ones in Spam PR. The rest is basically the same.

vttranlina pushed a commit to vttranlina/james-project that referenced this pull request Aug 10, 2022
vttranlina pushed a commit to vttranlina/james-project that referenced this pull request Aug 10, 2022
@vttranlina
Copy link
Copy Markdown
Contributor

The ci fail is not related to this pr

@vttranlina
Copy link
Copy Markdown
Contributor

Can you fix the typo "RSpamD" to "Rspamd"?

@quantranhong1999
Copy link
Copy Markdown
Member Author

Can you fix the typo "RSpamD" to "Rspamd"?

Me what I don't like is that instead of 1 PR doing 1 job that fixes the typo, now what you suggest is others n PRs doing both their job plus the fix the typo stuff.

Me I would prefer the typo PR to do its clean job eventually.

@chibenwa chibenwa merged commit 5cce1a5 into apache:master Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants