JAMES-3825 Cancel tasks upon graceful shutdown - waiting to the cancelled listener is completed #1272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibenwa
reviewed
Oct 25, 2022
server/task/task-memory/src/main/java/org/apache/james/task/SerialTaskManagerWorker.java
Outdated
Show resolved
Hide resolved
Member
quantranhong1999
left a comment
quantranhong1999
left a comment
There was a problem hiding this comment.
Read it. Nothing to add
Arsnael
approved these changes
Oct 25, 2022
Contributor
|
https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-1272/2/testReport/ 2 errors in SerialTaskManagerWorkerTest likely related. Please check |
chibenwa
approved these changes
Oct 25, 2022
Member
|
…lled listener is completed
vttranlina
force-pushed
the
task_grace_shutdown
branch
from
6eddc13 to
b2da311
Compare
Contributor
Author
|
please restart ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: The task has not been canceled before the shutdown of the server.
Related: