JAMES-2498 JDBCMailRepository should not materialize entities for counting them.#132
Closed
nstdio wants to merge 2 commits intoapache:masterfrom
Closed
JAMES-2498 JDBCMailRepository should not materialize entities for counting them.#132nstdio wants to merge 2 commits intoapache:masterfrom
nstdio wants to merge 2 commits intoapache:masterfrom
Conversation
…nting them. Executing SQL query for size.
mbaechler
reviewed
Jul 25, 2018
|
|
||
| @Override | ||
| public long size() throws MessagingException { | ||
| Connection conn = null; |
Member
There was a problem hiding this comment.
AFAIK all jdbc objects can by handled with a try-with-resource
Contributor
Author
There was a problem hiding this comment.
Sure! I was trying to follow common pattern used in the class.
Member
There was a problem hiding this comment.
In these cases, we often do a first commit to migrate code to the right code-style, then a second one with the change we want.
…for counting them.
chibenwa
approved these changes
Jul 26, 2018
Contributor
|
Hi, This pull request has just been merged. One very last thing: I don't have write access to this repository, hence I can not close this issue. Wouldn't you mind doing it for me? It would avoid me annoying the Apache INFRA team with such simple concerns. Thanks again, Cheers, Benoit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Executing SQL query for size.