JAMES-3754 Date searching should align IMAP4rev2 specifications#1360
Merged
chibenwa merged 1 commit intoapache:masterfrom Dec 28, 2022
Merged
JAMES-3754 Date searching should align IMAP4rev2 specifications#1360chibenwa merged 1 commit intoapache:masterfrom
chibenwa merged 1 commit intoapache:masterfrom
Conversation
chibenwa
approved these changes
Dec 14, 2022
Arsnael
approved these changes
Dec 14, 2022
quantranhong1999
force-pushed
the
align-imap-rev2-search
branch
from
0c721cf to
0e6270e
Compare
Focus on: BEFORE, ON, SINCE and same others https://www.rfc-editor.org/rfc/rfc9051.html#name-search-command
quantranhong1999
force-pushed
the
align-imap-rev2-search
branch
from
0e6270e to
fef9c10
Compare
chibenwa
approved these changes
Dec 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We did not align the specs for BEFORE, ON, SINCE ... commands for a few edge cases.
https://www.rfc-editor.org/rfc/rfc9051.html#name-search-command
With this change, this is how our internal API for date searching should work (Opensearch/Elasticsearch):
e.g User searches
SINCE <date>, we union ON and AFTER parts at IMAP layer => align the specMessages whose internal date (disregarding time and timezone) is within or later than the specified date.The same alignment is for other search date commands.