JAMES-3926 adopt cassandra quota helpers for mailbox quota limits#1706
Merged
Arsnael merged 3 commits intoapache:masterfrom Sep 7, 2023
Conversation
Arsnael
reviewed
Aug 30, 2023
Contributor
Arsnael
left a comment
Arsnael
left a comment
There was a problem hiding this comment.
I still see V1 automatically guice binded, not V2, and module chooser missing?
...rc/main/java/org/apache/james/mailbox/cassandra/quota/CassandraPerUserMaxQuotaManagerV2.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/james/mailbox/cassandra/quota/CassandraPerUserMaxQuotaManagerV2.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/james/mailbox/cassandra/quota/CassandraPerUserMaxQuotaManagerV2.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/james/mailbox/cassandra/quota/CassandraPerUserMaxQuotaManagerV2.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/james/mailbox/cassandra/quota/CassandraPerUserMaxQuotaManagerV2.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/james/mailbox/cassandra/quota/CassandraPerUserMaxQuotaManagerV2.java
Outdated
Show resolved
Hide resolved
...sandra/src/test/java/org/apache/james/mailbox/cassandra/CassandraMailboxManagerProvider.java
Outdated
Show resolved
Hide resolved
...x/cassandra/src/test/java/org/apache/james/mailbox/cassandra/CassandraTestSystemFixture.java
Outdated
Show resolved
Hide resolved
...a/org/apache/james/mailbox/cassandra/quota/CassandraPerUserMaxQuotaManagerMigrationTest.java
Outdated
Show resolved
Hide resolved
chibenwa
reviewed
Aug 30, 2023
.../java/org/apache/james/mailbox/cassandra/quota/CassandraPerUserMaxQuotaManagerMigration.java
Show resolved
Hide resolved
chibenwa
reviewed
Aug 30, 2023
.../java/org/apache/james/mailbox/cassandra/quota/CassandraPerUserMaxQuotaManagerMigration.java
Show resolved
Hide resolved
chibenwa
reviewed
Aug 30, 2023
...andra/src/test/java/org/apache/james/mpt/imapmailbox/cassandra/host/CassandraHostSystem.java
Outdated
Show resolved
Hide resolved
chibenwa
reviewed
Aug 30, 2023
Contributor
chibenwa
left a comment
chibenwa
left a comment
There was a problem hiding this comment.
If I am not wrong the CassandraMigration is not registered.
Arsnael
reviewed
Aug 30, 2023
...sandra/src/test/java/org/apache/james/mailbox/cassandra/CassandraMailboxManagerProvider.java
Outdated
Show resolved
Hide resolved
...x/cassandra/src/test/java/org/apache/james/mailbox/cassandra/CassandraTestSystemFixture.java
Outdated
Show resolved
Hide resolved
...andra/src/test/java/org/apache/james/mpt/imapmailbox/cassandra/host/CassandraHostSystem.java
Outdated
Show resolved
Hide resolved
...ner/guice/cassandra/src/main/java/org/apache/james/modules/mailbox/CassandraQuotaModule.java
Outdated
Show resolved
Hide resolved
Arsnael
approved these changes
Aug 31, 2023
Contributor
|
something missing with the guice bindings |
Contributor
|
Still one comment. And rebase is needed. |
hungphan227
force-pushed
the
JAMES-3926-Adopt-Cassandra-quota-helpers-for-Mailbox-quota-limits
branch
from
b8b7429 to
efe2cf3
Compare
chibenwa
reviewed
Sep 5, 2023
...rc/main/java/org/apache/james/mailbox/cassandra/quota/CassandraPerUserMaxQuotaManagerV2.java
Show resolved
Hide resolved
chibenwa
approved these changes
Sep 5, 2023
Contributor
|
Arsnael
approved these changes
Sep 5, 2023
quantranhong1999
approved these changes
Sep 5, 2023
hungphan227
force-pushed
the
JAMES-3926-Adopt-Cassandra-quota-helpers-for-Mailbox-quota-limits
branch
from
2924115 to
a576eae
Compare
chibenwa
approved these changes
Sep 6, 2023
Arsnael
approved these changes
Sep 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on #1700