JAMES-3953 Provide a file based blob store#1766
Merged
Arsnael merged 4 commits intoapache:masterfrom Nov 3, 2023
Merged
Conversation
Arsnael
reviewed
Oct 30, 2023
server/blob/blob-file/src/main/java/org/apache/james/blob/file/FileBlobStoreDAO.java
Outdated
Show resolved
Hide resolved
server/blob/blob-file/src/main/java/org/apache/james/blob/file/FileBlobStoreDAO.java
Show resolved
Hide resolved
server/blob/blob-file/src/main/java/org/apache/james/blob/file/FileBlobStoreDAO.java
Outdated
Show resolved
Hide resolved
server/blob/blob-file/src/main/java/org/apache/james/blob/file/FileBlobStoreFactory.java
Outdated
Show resolved
Hide resolved
...ce/distributed/src/main/java/org/apache/james/modules/blobstore/BlobStoreModulesChooser.java
Outdated
Show resolved
Hide resolved
quantranhong1999
approved these changes
Oct 30, 2023
server/blob/blob-file/src/main/java/org/apache/james/blob/file/FileBlobStoreFactory.java
Outdated
Show resolved
Hide resolved
Contributor
|
https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-1766/2/ Failed tests related |
db62cd2 to
a2a0ef8
Compare
Contributor
And next time fixups would be appreciated so we don't need to review the all PR again :) |
Arsnael
approved these changes
Nov 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the ticket for details but in short having such a card in the James game would ease integrating James into legacy storage systems, not cloud / s3 ready. Think ISCI, SAN, NAS and distributed systems like CEPH...