[PGSQL] Merge master branch to postgresql #1847
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents infinite email loop with forwards by tracking for which users the forwards where applied. Tracks both regular forwards and JMAP filters forwards. Co-authored-by: hung phan <hphan@linagora.com>
…RabbitMQ documentation.
…guration from rate-limiter-redis
…ing it to mpt imap test - The PostgresMailboxSessionMapperFactoryTODO was created independent of PostgresMailboxSessionMapperFactory for development. We need to remove MapperFactory, and rename MapperFactoryTODO -> MapperFactory when all dependencies already.
…dSafetyTest We do not control directly r2dbc-postgresql Connection but library owner, thus we can do nothing upon tests failure. But we can handle library failure at James layer using PostgresExecutor wrapper.
PreparedStatement id is unique per PG connection. We share a PG connection across multi threads leads to PreparedStatement id conflicts. We can retry upon PreparedStatement id conflicts.
…ct exception io.r2dbc.postgresql.ExceptionFactory$PostgresqlBadGrammarException: [42P05] prepared statement "S_0" already exists Should not retry upon other fatal exception e.g. database failure, invalid authorization...
Runs 41 tests more onto the PostgresMailboxManager
We generate a unique UUID so this is supported. Note that turns 5 tests on in the PostgresMailboxManager test suite.
- Use single query to database for fetch total + total unseen The query looks like: select count(*) as "total_count", count(*) filter (where is_seen = $1) as "unseen_count" from message_mailbox where mailbox_id = cast($2 as uuid)
- It is a why make lack of test case when run the test (jpaGuiceServerShouldUpdateQuota)
…ase sql validation - It was created for JPA, with Postgresql we don't need it. (instead of mark @disabled for it)
Fixed by JAMES-2586 Small codestyle refactorings.
…lict Otherwise, we could retry on other fatal errors like: io.r2dbc.postgresql.ExceptionFactory$PostgresqlBadGrammarException: column "domain" of relation "mailbox" already exists.
vttranlina
force-pushed
the
postgresql
branch
from
9c1ddb1 to
e51b002
Compare
Contributor
|
Github seems to say there is still conflicts? |
Contributor
Author
It looks better if the force push to |
Contributor
|
Force push are dangerous.... what about a PR with a rebase on origin/master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.