[JAMES-3897] Crowdsec SMTP connect hook#1994
Merged
jeantil merged 2 commits intoapache:masterfrom Feb 12, 2024
Merged
Conversation
chibenwa
reviewed
Feb 12, 2024
Contributor
chibenwa
left a comment
chibenwa
left a comment
There was a problem hiding this comment.
Huge +1. Thanks for this!
third-party/crowdsec/src/main/java/org/apache/james/crowdsec/CrowdsecSMTPConnectHandler.java
Show resolved
Hide resolved
chibenwa
approved these changes
Feb 12, 2024
EHLO is not required before sending AUTH, therefore blocking on EHLO does't work very well against bruteforce attempts This commit introduces a hard connection close when a banned ip attempts to connect again to james.
jeantil
force-pushed
the
crowdsec-connect-hook
branch
from
5e89d68 to
f774eb9
Compare
Contributor
Author
|
There was a green build before I rebased to include the readme fix. master has not changed since then so I will consider this as flakyness in the test suite |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EHLO is not required before sending AUTH, therefore blocking on EHLO does't work very well against bruteforce attempts.
This PR introduces a hard connection close when a banned ip attempts to connect again to james even before the IP can send any SMTP command.