Skip to content

JAMES-3221 Simple implementation for logging configuration file paths#208

Merged
asfgit merged 1 commit intoapache:masterfrom
ieugen:JAMES-3221-log-configs
Jun 17, 2020
Merged

JAMES-3221 Simple implementation for logging configuration file paths#208
asfgit merged 1 commit intoapache:masterfrom
ieugen:JAMES-3221-log-configs

Conversation

@ieugen
Copy link
Copy Markdown
Member

@ieugen ieugen commented Jun 16, 2020

  • When loading a configuration file, print it's absolute path.
  • Usefull for debugging production miss-configurations

https://issues.apache.org/jira/browse/JAMES-3221

@ieugen
Copy link
Copy Markdown
Member Author

ieugen commented Jun 16, 2020

Sample output:

3:05:46,291 |-INFO in ch.qos.logback.classic.joran.action.ConfigurationAction - End of configuration.
03:05:46,293 |-INFO in ch.qos.logback.classic.joran.JoranConfigurator@524d6d96 - Registering current configuration as safe fallback point

Starting Apache James
Load logging config from /home/ieugen/proiecte/james/james-self-hosting-sandbox/conf/logback.xml
03:05:46.327 [INFO ] o.a.j.JPAJamesServerMain - Loading configuration Basic{configurationPath=ConfigurationPath{value=file://conf/}, directories=JamesServerResourceLoader{rootDirectory=/home/ieugen/proiecte/james/james-self-hosting-sandbox/, varDirectory=/home/ieugen/proiecte/james/james-self-hosting-sandbox//var/, confDirectory=/home/ieugen/proiecte/james/james-self-hosting-sandbox//conf/}}
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.google.inject.internal.cglib.core.$ReflectUtils$1 (file:/home/ieugen/.m2/repository/com/google/inject/guice/4.2.2/guice-4.2.2.jar) to method java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain)
WARNING: Please consider reporting this to the maintainers of com.google.inject.internal.cglib.core.$ReflectUtils$1
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
03:05:48.002 [INFO ] o.a.j.StartUpChecksPerformer - StartUpChecks all succeeded
03:05:48.135 [INFO ] o.a.j.u.PropertiesProvider - Load configuration file /home/ieugen/proiecte/james/james-self-hosting-sandbox/conf/healthcheck.properties
03:05:48.251 [INFO ] o.a.c.b.FluentPropertyBeanIntrospector - Error when creating PropertyDescriptor for public final void org.apache.commons.configuration2.AbstractConfiguration.setProperty(java.lang.String,java.lang.Object)! Ignoring this property.
03:05:48.275 [INFO ] o.a.j.u.PropertiesProvider - Load configuration file /home/ieugen/proiecte/james/james-self-hosting-sandbox/conf/james-database.properties

@ieugen ieugen force-pushed the JAMES-3221-log-configs branch from 3f3cba4 to beb0918 Compare June 16, 2020 09:25
@ieugen
Copy link
Copy Markdown
Member Author

ieugen commented Jun 16, 2020

I just pushed. It's a bit more polished.
Please review.
Merge if you it's ok.
We can't get much more out of this now.

@rouazana
Copy link
Copy Markdown
Member

what do you think of #208 (comment) ?

@ieugen ieugen force-pushed the JAMES-3221-log-configs branch from beb0918 to a103032 Compare June 16, 2020 10:41
@ieugen
Copy link
Copy Markdown
Member Author

ieugen commented Jun 16, 2020

what do you think of #208 (comment) ?

Done. Missed that. Thanks.

@ieugen ieugen self-assigned this Jun 16, 2020
@ieugen ieugen force-pushed the JAMES-3221-log-configs branch from a103032 to 096dd8c Compare June 16, 2020 11:05
Copy link
Copy Markdown
Member

@mbaechler mbaechler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ieugen for this contribution, it's cool to see people care about details we overlooked for now

Copy link
Copy Markdown
Member

@rouazana rouazana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

…evops

* When loading a configuration file, print it's absolute
* Usefull for debugging production miss-configurations
* Added documentation
@ieugen ieugen force-pushed the JAMES-3221-log-configs branch from 096dd8c to b90d05e Compare June 17, 2020 19:37
@asfgit asfgit merged commit b90d05e into apache:master Jun 17, 2020
@ieugen ieugen deleted the JAMES-3221-log-configs branch June 17, 2020 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants