[FIX] AESBlobStoreDAO caused IMAP FETCH to fail when using S3 as a ba…#2174
Merged
Arsnael merged 2 commits intoapache:masterfrom Apr 4, 2024
Merged
[FIX] AESBlobStoreDAO caused IMAP FETCH to fail when using S3 as a ba…#2174Arsnael merged 2 commits intoapache:masterfrom
Arsnael merged 2 commits intoapache:masterfrom
Conversation
When using the AES blobStore, switching the S3 object consumption out of the eventLoop causes the allocation of ByteBuf items onto the boundedElastic scheduler. As ByteBuf allocation relies on ThreadLocal, this in turn causes the instantiation of a way-too-large count of Netty ByteBuf arena and can be perceived as a Native memory leak (far over 1GB allocation, while before usage was limited to ~150MB). As we cannot rely on the previous patch that did block on the S3 driver Netty event loop, and as we cannot keep the current native memory over-consumption, this patch disables the intermediary file buffering when using the AESBlobStore. This was introduced in the first place to mitigate the lack of IMAP backpressure. That being solved we can afford paying a bit of HEAP onto the AES blob store. Note the approximate pre-sizing of the output stream in order to limit allocation.
Arsnael
approved these changes
Apr 4, 2024
quantranhong1999
approved these changes
Apr 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ckend