James 1902 extract some guice modules #258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arsnael
approved these changes
Nov 2, 2020
| MailRepositoryStoreConfiguration provideConfiguration(ConfigurationProvider configurationProvider, DefaultItemSupplier defaultItemSupplier) throws ConfigurationException { | ||
| MailRepositoryStoreConfiguration provideConfiguration(ConfigurationProvider configurationProvider, | ||
| Provider<MailRepositoryStoreConfiguration.Item> defaultConfigurationItem) | ||
| throws ConfigurationException { |
Contributor
There was a problem hiding this comment.
I would have put that on the line above, this looks odd when I read it
Member
Author
There was a problem hiding this comment.
It would make the line very long, I didn't found a good solution for it.
chibenwa
approved these changes
Nov 2, 2020
Contributor
chibenwa
left a comment
chibenwa
left a comment
There was a problem hiding this comment.
I'm fine with this work.
Member
Author
|
@chibenwa be careful to synchronize linagora's branch when I merge PR's on apache repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.