Close BufferedReader in addProtocolLines#2981
Merged
chibenwa merged 1 commit intoMar 23, 2026
Merged
Conversation
chibenwa
approved these changes
Mar 23, 2026
Contributor
chibenwa
left a comment
chibenwa
left a comment
There was a problem hiding this comment.
Thanks a lot!
Don t hesitate if you have other enhancements.
Best regards
Benoit
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was reading through mpt/core/src/main/java/org/apache/james/mpt/protocol/ProtocolSessionBuilder.java and the resource opened there can leak if addProtocolLines exits on an error path. this patch moves the allocation into try-with-resources so cleanup happens on every exit path. Not sure if this is intentional, so feel free to ignore.
Happy to revise the approach or close this if it doesn’t fit — you know the codebase far better than I do.