JAMES-3491 Configurable websocket URL for JMAP configuration#422
Merged
chibenwa merged 2 commits intoapache:masterfrom May 18, 2021
Merged
JAMES-3491 Configurable websocket URL for JMAP configuration#422chibenwa merged 2 commits intoapache:masterfrom
chibenwa merged 2 commits intoapache:masterfrom
Conversation
Contributor
|
I think |
chibenwa
reviewed
May 7, 2021
...-integration-tests/memory-jmap-rfc-8621-integration-tests/src/test/resources/jmap.properties
Outdated
Show resolved
Hide resolved
LanKhuat
force-pushed
the
jmap-protocol-configuration
branch
from
fc17855 to
1bdb32b
Compare
LanKhuat
changed the title
LanKhuat
changed the title
Contributor
|
Several tests are failing. Can you have a look @LanKhuat ? https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-422/3/ |
Arsnael
approved these changes
May 11, 2021
chibenwa
approved these changes
May 11, 2021
Contributor
|
@LanKhuat can you squash this? |
chibenwa
force-pushed
the
jmap-protocol-configuration
branch
from
a572c41 to
d836545
Compare
Contributor
|
I did squash it myself ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow for more flexibility in advertising URLs in the session object.