James 1773 - Rework HasHeader tests and documentation#46
Closed
chibenwa wants to merge 5 commits intoapache:masterfrom
Closed
James 1773 - Rework HasHeader tests and documentation#46chibenwa wants to merge 5 commits intoapache:masterfrom
chibenwa wants to merge 5 commits intoapache:masterfrom
Conversation
What was not tested ? - multi-conditions - header present multiples times (buggy) - header with value specified
I did not use Guava for refactoring as it is not present in this project. The idea is to introduce specific objects for conditions, that will be parsed once and for all.
Contributor
Author
|
CI tests are Ok |
Member
|
👍 |
Contributor
Author
|
Merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first one of a long list.
I upgraded test quality, added tests, updated documentation.
Finally, I changed the behaviour of the mailet so that it do not parse conditions on each received e-mail!