Limit the heap size of Cassandra and ES docker containers for tests#469
Merged
Conversation
vttranlina
approved these changes
Jun 1, 2021
chibenwa
approved these changes
Jun 1, 2021
Contributor
Author
|
First build: green :) |
Contributor
Author
|
Tsss not sure related |
Contributor
Author
|
One green and one red: Not related either... |
Contributor
Author
Hmmm... Not sure what to think of this one. Well I'm gonna raise up a bit to be sure |
Contributor
Author
|
2 greens builds :) Ok I squash the fixups and if I get an other green I merge |
It was not working, as in testcontainers we know we define an ENV variable by using the `env()` method, so declaring "ENV" in the key is a mistake. It's been a long time this is intended to run as 650M heap memory size for Cassandra, while in fact it's been the default 4Go running meanwhile.
The default is 1Go. I'm betting on half here (512M).
acf5ac9 to
adb7a56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Well as I'm getting tired of having the RAM of my laptop burning to the ground half of the time I run integration tests on James, I decided to take a closer look.
Cassandra by default is deployed with 4Go RAM of heap. ES is deployed with 1Go (well I observed those when running locally)
Now the interesting thing is that some work has been done a while ago to limit the size of Cassandra to 650M for the tests, but the env variable setup was wrong. Thus we were still living with a 4Go memory eater Cassandra.
I fixed that, and while I was at it, I'm taking a shot at ES too (half, from 1Go to 512M). The rational being, if it passes with Cassandra limited like this, might be as well with ES.
I would like to have a good bunch of CI runs though first to be sure it does not bring instability to the build. If it does, I will change those values and go up gradually until we got a stable build.
If any feedback on this or proposition, don't hesitate :)