JAMES-3516 Implement ThreadIdGuessingAlgorithm for Distributed module#554
Merged
Arsnael merged 2 commits intoAug 5, 2021
Merged
Conversation
chibenwa
reviewed
Jul 27, 2021
Member
Author
|
At DistributedThreadGetTest:
At CassandraThreadIdGuessingAlgorithmTest which uses SimpleMessageSearchIndex does not work properly also. This is really weird. My guess is we have a bug when SearchIndex indexes/query threadId which wraps CassandraMessageId (because it still works properly with InMemoryMessageId). |
chibenwa
reviewed
Jul 28, 2021
Arsnael
approved these changes
Jul 29, 2021
chibenwa
approved these changes
Jul 29, 2021
Contributor
chibenwa
left a comment
chibenwa
left a comment
There was a problem hiding this comment.
Can you squash @quantranhong1999 ?
quantranhong1999
force-pushed
the
threadIdGuessingForCassandraModule
branch
from
2b41b43 to
e8f9310
Compare
Member
Author
Done. We need this to be merged #550. Then I can remove the NO REVIEW commit. |
…dId not from naive ThreadId This change allows CassandraMessageMapper save mailbox message with guessed ThreadId.
quantranhong1999
force-pushed
the
threadIdGuessingForCassandraModule
branch
from
e8f9310 to
bc39f03
Compare
Member
Author
|
The CI build failed with weird errors. Can someone restart it? |
Contributor
|
yes maybe a network issue with jib. I restarted the build |
Member
Author
These seem not related, green on my local btw. |
Contributor
|
Looks like it's not... restarted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem now is that the new message can't find related thread data from the thread table.
My guess is the Cassandra write is not finished yet before other new messages coming, or maybe even my code writing to Cassandra is not working.
I am working on this.