JAMES-3658 LocalResourcesImpl should public constructor #688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vttranlina
force-pushed
the
JAMES-3658
branch
from
eff07e9 to
16fb3bf
Compare
Arsnael
approved these changes
Oct 12, 2021
chibenwa
approved these changes
Oct 12, 2021
vttranlina
force-pushed
the
JAMES-3658
branch
from
16fb3bf to
4ebded5
Compare
chibenwa
approved these changes
Oct 13, 2021
Contributor
Author
|
I don't know why ci fail, I rebased with the latest master branch. |
Contributor
definitely not your fault... is there a maven issue on the CI? |
Contributor
|
A classic one: I often see this problem 5-6 time on PRs. If you keep relaunching it eventually solves itself. No explanation. Long term fixing plan: remove spring... :-) |
Contributor
Author
|
CI passed on the clone pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to easier for reusable