JAMES-3539 Implement inmemory PushSubscriptionRepository and contract tests#707
Merged
Arsnael merged 1 commit intoapache:masterfrom Oct 28, 2021
Merged
Conversation
chibenwa
reviewed
Oct 22, 2021
server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/mail/PushSubscription.scala
Outdated
Show resolved
Hide resolved
...-8621/src/main/scala/org/apache/james/jmap/pushsubscription/PushSubscriptionRepository.scala
Outdated
Show resolved
Hide resolved
...fc-8621/src/main/scala/org/apache/james/jmap/pushsubscription/InMemoryPushSubscription.scala
Outdated
Show resolved
Hide resolved
...fc-8621/src/main/scala/org/apache/james/jmap/pushsubscription/InMemoryPushSubscription.scala
Outdated
Show resolved
Hide resolved
...fc-8621/src/main/scala/org/apache/james/jmap/pushsubscription/InMemoryPushSubscription.scala
Outdated
Show resolved
Hide resolved
...fc-8621/src/main/scala/org/apache/james/jmap/pushsubscription/InMemoryPushSubscription.scala
Outdated
Show resolved
Hide resolved
...fc-8621/src/main/scala/org/apache/james/jmap/pushsubscription/InMemoryPushSubscription.scala
Outdated
Show resolved
Hide resolved
...fc-8621/src/main/scala/org/apache/james/jmap/pushsubscription/InMemoryPushSubscription.scala
Outdated
Show resolved
Hide resolved
...map/src/main/java/org/apache/james/jmap/api/pushsubscription/PushSubscriptionRepository.java
Outdated
Show resolved
Hide resolved
...test/java/org/apache/james/jmap/api/pushsubscription/PushSubscriptionRepositoryContract.java
Outdated
Show resolved
Hide resolved
server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/core/PushSubscription.scala
Outdated
Show resolved
Hide resolved
server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/core/PushSubscription.scala
Show resolved
Hide resolved
server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/core/PushSubscription.scala
Outdated
Show resolved
Hide resolved
server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/core/PushSubscription.scala
Outdated
Show resolved
Hide resolved
chibenwa
reviewed
Oct 25, 2021
...java/org/apache/james/jmap/api/pushsubscription/PushSubscriptionVerificationCodeFactory.java
Outdated
Show resolved
Hide resolved
server/data/data-jmap/src/main/scala/org/apache/james/jmap/api/model/PushSubscription.scala
Outdated
Show resolved
Hide resolved
server/data/data-jmap/src/main/scala/org/apache/james/jmap/api/model/TypeName.scala
Outdated
Show resolved
Hide resolved
server/data/data-jmap/src/main/scala/org/apache/james/jmap/api/model/UuidState.scala
Outdated
Show resolved
Hide resolved
...ain/java/org/apache/james/jmap/memory/pushsubscription/MemoryPushSubscriptionRepository.java
Outdated
Show resolved
Hide resolved
...ain/java/org/apache/james/jmap/memory/pushsubscription/MemoryPushSubscriptionRepository.java
Outdated
Show resolved
Hide resolved
...ain/java/org/apache/james/jmap/memory/pushsubscription/MemoryPushSubscriptionRepository.java
Outdated
Show resolved
Hide resolved
...java/org/apache/james/jmap/memory/pushsubscription/MemoryPushSubscriptionRepositoryTest.java
Outdated
Show resolved
Hide resolved
...st/scala/org/apache/james/jmap/api/pushsubscription/PushSubscriptionRepositoryContract.scala
Outdated
Show resolved
Hide resolved
...st/scala/org/apache/james/jmap/api/pushsubscription/PushSubscriptionRepositoryContract.scala
Outdated
Show resolved
Hide resolved
chibenwa
reviewed
Oct 26, 2021
server/data/data-jmap/src/main/scala/org/apache/james/jmap/api/model/PushSubscription.scala
Outdated
Show resolved
Hide resolved
chibenwa
reviewed
Oct 26, 2021
...er/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/routes/WebSocketRoutes.scala
Outdated
Show resolved
Hide resolved
chibenwa
reviewed
Oct 26, 2021
...r/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/json/EmailGetSerializer.scala
Outdated
Show resolved
Hide resolved
chibenwa
reviewed
Oct 26, 2021
...a-jmap/src/main/java/org/apache/james/jmap/api/pushsubscription/PushSubscriptionBuilder.java
Outdated
Show resolved
Hide resolved
chibenwa
reviewed
Oct 26, 2021
...map/src/main/java/org/apache/james/jmap/api/pushsubscription/PushSubscriptionRepository.java
Outdated
Show resolved
Hide resolved
...ain/java/org/apache/james/jmap/memory/pushsubscription/MemoryPushSubscriptionRepository.java
Outdated
Show resolved
Hide resolved
...ain/java/org/apache/james/jmap/memory/pushsubscription/MemoryPushSubscriptionRepository.java
Outdated
Show resolved
Hide resolved
...ain/java/org/apache/james/jmap/memory/pushsubscription/MemoryPushSubscriptionRepository.java
Outdated
Show resolved
Hide resolved
...ain/java/org/apache/james/jmap/memory/pushsubscription/MemoryPushSubscriptionRepository.java
Outdated
Show resolved
Hide resolved
server/data/data-jmap/src/main/scala/org/apache/james/jmap/api/model/UuidState.scala
Outdated
Show resolved
Hide resolved
...st/scala/org/apache/james/jmap/api/pushsubscription/PushSubscriptionRepositoryContract.scala
Outdated
Show resolved
Hide resolved
...r/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/json/EmailSetSerializer.scala
Outdated
Show resolved
Hide resolved
...er/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/routes/WebSocketRoutes.scala
Outdated
Show resolved
Hide resolved
...er/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/routes/WebSocketRoutes.scala
Outdated
Show resolved
Hide resolved
Arsnael
approved these changes
Oct 27, 2021
Contributor
|
Bunch of errors similar to this in |
chibenwa
approved these changes
Oct 27, 2021
… tests Refactoring TypeName and State trait location included
quantranhong1999
force-pushed
the
pushSubRepository
branch
from
dde75df to
dc5231a
Compare
vttranlina
approved these changes
Oct 28, 2021
Contributor
vttranlina
left a comment
vttranlina
left a comment
There was a problem hiding this comment.
the moving TypeName should be in another commit will more clear
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: write tests