JAMES-3693 Rate limiter - update pom #878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arsnael
approved these changes
Feb 7, 2022
| <dependency> | ||
| <groupId>${james.groupId}</groupId> | ||
| <artifactId>james-server-core</artifactId> | ||
| <scope>provided</scope> |
Member
There was a problem hiding this comment.
Q: Why do you add this scope?
Contributor
Author
There was a problem hiding this comment.
Similar to other dependencies, for external jar
Member
There was a problem hiding this comment.
As far as I read on stackoverflow and what I understand, this is to avoid duplicating the dependency when importing the JAR to another project (here is james-server-core dependency and james project).
Contributor
There was a problem hiding this comment.
Yes that's not to include it in the JAR with dependencies as we do not need it!
quantranhong1999
approved these changes
Feb 7, 2022
chibenwa
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.