JAMES-3715 Small round of Netty4 polishing #926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arsnael
reviewed
Mar 23, 2022
mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/GhostMailbox.java
Outdated
Show resolved
Hide resolved
chibenwa
force-pushed
the
netty4-fixes-3
branch
3 times, most recently
from
fe3f104 to
fc18c29
Compare
Contributor
Author
|
Forced pushed to remove the last commit which was unrelated.. Was 🍏 |
Arsnael
approved these changes
Mar 29, 2022
CF https://issues.redhat.com/browse/NETTY-311 Don't add these items to the pipeline if they are not used... Also a volatile variable was immutable and could be final. Remove NETTY-311 todos: that contribution aborted...
…ed upon insert conflict
…stream Was always null...
This stacktrace is never used...
If it fits in memory it is not worth chucking...
Building MDC for this takes 0.37% of CPU even when nothing is logged on the sample IMAP benchmarks I run, and account for 2.6% of overall memory allocation, even if nothing is ever logged. Even on JMAP scenario this account for 0.2% of CPU time. Easy fix... Do the MDC stuff only if needed...
chibenwa
force-pushed
the
netty4-fixes-3
branch
from
fc18c29 to
8fd5257
Compare
Contributor
Author
|
Forced pushed to solve a rebase conflict... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased version of #903
TODO quich performance checks.