Skip to content

[PERF] Thread configuration for WebAdmin, redis and some reactor improvments#950

Merged
chibenwa merged 6 commits intoapache:masterfrom
chibenwa:threads-rework
Apr 8, 2022
Merged

[PERF] Thread configuration for WebAdmin, redis and some reactor improvments#950
chibenwa merged 6 commits intoapache:masterfrom
chibenwa:threads-rework

Conversation

@chibenwa
Copy link
Copy Markdown
Contributor

@chibenwa chibenwa commented Apr 4, 2022

No description provided.

@chibenwa
Copy link
Copy Markdown
Contributor Author

chibenwa commented Apr 4, 2022

org.apache.james.events.RabbitMQEventBusTest.eventProcessingShouldStoreInvalidMessagesInDeadLetterQueue
org.apache.james.events.RabbitMQEventBusTest.eventProcessingShouldNotCrashOnInvalidMessages 
org.apache.james.events.RabbitMQEventBusTest.eventProcessingShouldNotCrashOnInvalidMessage 
org.apache.james.webadmin.WebAdminConfigurationTest.shouldMatchBeanContract

Likely related

@Arsnael
Copy link
Copy Markdown
Contributor

Arsnael commented Apr 4, 2022

Some errors in RabbitMQEventBusTest likely linked to your change on event executions:

org.apache.james.events.RabbitMQEventBusTest.eventProcessingShouldStoreInvalidMessagesInDeadLetterQueue
org.awaitility.core.ConditionTimeoutException: 
Assertion condition defined as a lambda expression in org.apache.james.events.RabbitMQEventBusTest that uses java.util.concurrent.atomic.AtomicInteger 
expected: 1
 but was: 0 within 10 seconds.
	at org.apache.james.events.RabbitMQEventBusTest.eventProcessingShouldStoreInvalidMessagesInDeadLetterQueue(RabbitMQEventBusTest.java:247)
Caused by: org.opentest4j.AssertionFailedError: 

expected: 1
 but was: 0
	at org.apache.james.events.RabbitMQEventBusTest.lambda$eventProcessingShouldStoreInvalidMessagesInDeadLetterQueue$5(RabbitMQEventBusTest.java:247)

And one related to your change on the webadmin conf:

org.apache.james.webadmin.WebAdminConfigurationTest.shouldMatchBeanContract
EqualsVerifier found a problem in class org.apache.james.webadmin.WebAdminConfiguration.
-> Significant fields: equals does not use maxThreadCount, or it is stateless.

@chibenwa chibenwa merged commit 607928c into apache:master Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants