This repository was archived by the owner on Aug 6, 2025. It is now read-only.
Jclouds 1615 #155
Merged
Jclouds 1615 #155
+61
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaul
suggested changes
Oct 13, 2022
| String blockId = AzureBlobStore.makeBlockId(partNumber); | ||
| // if (!blockId.matches(VALIDATION_REGEX)){ | ||
| // System.out.println("--------------------------------------------- " + partNumber + " -> '" + blockId + "' -> " + blockId.matches(VALIDATION_REGEX)); | ||
| //} |
Member
There was a problem hiding this comment.
Please remove this commented code.
| @Test(groups = "unit", testName = "AzureBlobStore") | ||
| public class AzureBlobStoreTest { | ||
|
|
||
| static String VALIDATION_REGEX = "[a-zA-Z0-9\\-_=]*"; |
Member
There was a problem hiding this comment.
Can you make this private and final and use Pattern.compile??
Author
There was a problem hiding this comment.
... i did so ... hope you like it.
Member
|
Thank you for your contribution @ChJung1! |
|
I have tested some simple things with the current JCloud master branch code base against an Azure storage account and run into an error message for a 4 gigabyte upload, split into 5 MByte chunks in a multipart upload: Could it be, that the base64 encoding in the url version isn't accepted by Azure? |
Author
|
Hi Steffen Gürtler,
I did the pull request for the encoding with Base64Url, because with Base64 i got an error similar to yours.
Base64Url is meant to ensure you can use the string in urls.
The string you have contains a minus sign, so this is indeed Base64Url, and not Base64, so my fix is in there.
Your problem looks very similar to mine, so is it maybe the "==" this time?
BTW, while changing the code i wondered if we could implement makeBlockId() by using String.valueOf() instead,
which is much simpler code, a shorter string, and uses only digits (as Block-ID is an integer and probably positive)
Feel free to try that, and if it helps you can maybe also remove that not-so-helpful test I added.
Andrew Gaul will then hopefully approve your pull request.
Good luck!
ChJung1
Gesendet: Dienstag, 25. Juli 2023 um 18:07 Uhr
Von: "Steffen Gürtler" ***@***.***>
An: "apache/jclouds" ***@***.***>
Cc: "ChJung1" ***@***.***>, "Mention" ***@***.***>
Betreff: Re: [apache/jclouds] Jclouds 1615 (PR #155)
I have tested some simple things with the current JCloud master branch code base against an Azure storage account and run into an error message for a 4 gigabyte upload, split into 5 MByte chunks in a multipart upload:
Could it be, that the base64 encoding in the url version isn't accepted by Azure?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Member
|
Please open a Jira issue for this regression. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @gaul,
This is my first github pull request, so forgive me if i did something the wrong way.
I tried to add a test, but feel that it kind of doesn't test the core of the problem.
Feedback welcome.
ChJung1