Fixing namespaceTTL (was recursively calling itself)#102
Merged
Conversation
asfgit
pushed a commit
that referenced
this pull request
Nov 24, 2015
Member
|
Thanks for the fix, applied to trunk I notice the method definition looks a bit odd in general - @afs should i.e. should |
Contributor
Author
|
I think that the escaping is only needed for the localname -- the namespace URI will usually contain characters ( |
Member
|
@escowles is right - escaping is only allowed in the local part. Also, the return from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.