Skip to content

Fixing namespaceTTL (was recursively calling itself)#102

Merged
asfgit merged 1 commit into
apache:masterfrom
escowles:namespace-ttl
Nov 24, 2015
Merged

Fixing namespaceTTL (was recursively calling itself)#102
asfgit merged 1 commit into
apache:masterfrom
escowles:namespace-ttl

Conversation

@escowles
Copy link
Copy Markdown
Contributor

No description provided.

@asfgit asfgit merged commit e845227 into apache:master Nov 24, 2015
asfgit pushed a commit that referenced this pull request Nov 24, 2015
@rvesse
Copy link
Copy Markdown
Member

rvesse commented Nov 24, 2015

Thanks for the fix, applied to trunk

I notice the method definition looks a bit odd in general - @afs should namespaceTTL() have a similar definition to localnameTTL() where it first calls localname() and then applies escaping?

i.e. should namespaceTTL() be calling namespace() and then applying escaping to the results?

@escowles
Copy link
Copy Markdown
Contributor Author

I think that the escaping is only needed for the localname -- the namespace URI will usually contain characters (.-/#) that would be improperly escaped by escape_PN_LOCAL_ESC().

@afs
Copy link
Copy Markdown
Member

afs commented Nov 24, 2015

@escowles is right - escaping is only allowed in the local part. Also, the return from namespaceTTL is a IRI, to go in <...>, not the prefix name that is written in output as a bare word.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants