Skip to content

JENA-2232: Fix javadoc production for java11#1144

Merged
afs merged 1 commit intoapache:mainfrom
afs:javadoc-modules-fix
Dec 29, 2021
Merged

JENA-2232: Fix javadoc production for java11#1144
afs merged 1 commit intoapache:mainfrom
afs:javadoc-modules-fix

Conversation

@afs
Copy link
Copy Markdown
Member

@afs afs commented Dec 28, 2021

No description provided.

Comment thread jena-geosparql/pom.xml
is string based of WKT.
-->
<profile>
<id>java-after-8</id>
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No-op. Jena now requires java11.

Comment thread pom.xml
<artifactId>maven-javadoc-plugin</artifactId>
<configuration>
<!-- Java 11 only, removed at Java13 -->
<additionalOptions>--no-module-directories</additionalOptions>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it break the build if someone uses Java13?

Copy link
Copy Markdown
Member Author

@afs afs Dec 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java 13 is EOL. The non-LTS have a lifetime of 6 months. No one should be using it (but ...)

It is not a problem in Java17 (which is LTS).

What does matter is that the flag has been removed and is illegal from Java13 and importantly in Java17 (the javadoc plugin exits with an error).

https://bugs.openjdk.java.net/browse/JDK-8215291 says fixed at 13 (and the flag --no-module-directories removed).
The fix has been backported to java 12.

There is an open task to backport to Java11 (LTS) but no progress.
https://bugs.openjdk.java.net/browse/JDK-8244171

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not a problem in Java17 (which is LTS).

Ah, perfect. I thought it would break on 13+, not only on 13 👍

Thanks! #TodayILearned :)

@afs afs merged commit 0fe1bbf into apache:main Dec 29, 2021
@afs afs deleted the javadoc-modules-fix branch December 29, 2021 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants