JENA-508: Partial implementation of Xpath3 functions (fn:normalize-space, fn:normalize-unicode and fn:round-half-to-even)#144
Merged
asfgit merged 7 commits intoapache:masterfrom May 17, 2016
Conversation
First implementation of fn:normalize-space: function and tests.
First implementation of fn:normalized-unicode with tests. Some doubt remain for part of the implementation.
I implemented fn:round-to-half-even. While implementing it, I realized that the fn:round function was not following the xpath3 directive and I thus changed it. Still as the round function (without fn) is used in SPARQL and SPARQL 1.1 seems to be based on Xpath2 (true?), I created a new roundxpath3 function that is implementing the xpath3 specs.
Tried to solve the problems on the test 10 and 11 for the NormalizeUnicode function but could not solve it fully.
asfgit
pushed a commit
that referenced
this pull request
May 17, 2016
Member
|
Tests: exprStrNormalizeUnicode10, exprStrNormalizeUnicode11 I don't know why they are failing either. May be it's because the version of Unicodein Java is not new enough. I've commented these out for the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented the three Xpath3 functions:
I tested the functionality taking the examples from the specs (xpath or unicode).
I still have one problem with 2 tests exprStrNormalizeUnicode10 and exprStrNormalizeUnicode11 that are not passing. I wrote in the comment of the test my findings but I am not sure how to go on from here. Someone could help?
Also while creating fn:round-half-to-even I realized that fn:round-half is not following the Xpath3 specs. I thus changes also the fn:round-half implementation. Still as I saw that the function used for fn:round-half we used for SPARQL ROUND, I decided to separate the two functions. Not sure if also SPARQL ROUND should be implemented following the Xpath 3 spec.