JENA-1222 and JENA-1224: Flush queue when large by byte size or by pending commits. #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // System.err.printf("checkForJournalFlush: queue size=%d; journal size = %d\n", queue.size(), journal.size()) ; | ||
| // System.err.printf("checkForJournalFlush: QueueBatchSize=%d; MaxQueueThreshold=%d; JournalThresholdSize=%d\n", | ||
| // QueueBatchSize, MaxQueueThreshold, JournalThresholdSize) ; | ||
| if ( QueueBatchSize == 0 ) |
Member
There was a problem hiding this comment.
I'm probably missing something, but it seems like this is part of the next case (isn't queue.size() >= 0 an invariant?). Is this called out just to emphasize that setting 0 => "no queuing"?
Member
Author
There was a problem hiding this comment.
True - remains of when JENA-1224 (excessive queue length was handled here ... bit that didn't work out). Tiding up done in the next commit.
asfgit
pushed a commit
that referenced
this pull request
Aug 23, 2016
xristy
added a commit
that referenced
this pull request
Nov 7, 2019
* fix lds-pdi #164 : correct effectiveFIeld, add lang highlight test * remove unused parameter, useDocLang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds additional control over the queue in the journal.
If the journal gets large, as measured by the journal file size in bytes (JENA-1222) then try to flush the journal.
If the journal becomes excessive long in terms of pending commits (JENA-1224) then after a writer, flip to exclusive mode, flush the journal and flip back to normal mode.