Skip to content

SORT_ARGS behavior#181

Merged
asfgit merged 2 commits into
apache:masterfrom
ajs6f:patch-1
Oct 23, 2016
Merged

SORT_ARGS behavior#181
asfgit merged 2 commits into
apache:masterfrom
ajs6f:patch-1

Conversation

@ajs6f
Copy link
Copy Markdown
Member

@ajs6f ajs6f commented Oct 21, 2016

Allow env variable SORT_ARGS to be used for multiflag sort args
Do not override parallel flag if it is set on CLI in --sort-args or in env SORT_ARGS

@ajs6f ajs6f force-pushed the patch-1 branch 2 times, most recently from 5c22242 to 35c0d36 Compare October 21, 2016 15:13
Comment thread apache-jena/bin/tdbloader2index Outdated
DEBUG=0
JVM_ARGS=
SORT_ARGS=
if [ -n $SORT_ARGS ]; then
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to use "" or use [[ ]]

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right. Will fix.

KEEP_WORK=0
DEBUG=0
JVM_ARGS=
SORT_ARGS=
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can use SORT_ARGS="${SORT_ARGS:-}" to set to environment or empty string.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I'll fix this.

ajs6f and others added 2 commits October 23, 2016 15:15
Allow env variable SORT_ARGS to be used for multiflag sort args
Do not override parallel flag if it is set on CLI in --sort-args or in env SORT_ARGS
@asfgit asfgit merged commit d3b9c46 into apache:master Oct 23, 2016
@ajs6f ajs6f deleted the patch-1 branch October 23, 2016 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants