Skip to content

Conversation

@afs
Copy link
Member

@afs afs commented Jun 21, 2023

GitHub issue resolved #1913

Pull request Description: See #1913.

Some people have had setup problems setting up Jena in an IDE because of the IDE gets confused by jena-shaded-guava. This friction should go away by using unshaded alternatives.

Google guava is still in use - as an unshaded dependency in jena-serviceenhancer but for other use isn't a dependency.

jsonld-java has its own shaded google-guava artifact.


  • Commits have been squashed to remove intermediate development commit messages.
  • Key commit messages start with the issue number (GH-xxxx, or if in JIRA, JENA-xxxx)

By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.

@afs afs changed the title Don't have a shaded Google Guava artifact. Use alternative class where possible. GH-1913: Don't have a shaded Google Guava artifact. Use alternative class where possible. Jun 21, 2023
Copy link
Member

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked about 1/3 of the files and these were looking good! +1 from me 👏 Going to be a lot easier to use Jena in Eclipse now!

@afs
Copy link
Member Author

afs commented Jun 21, 2023

This PR also, accidentally (!!), fixes the Jenkins build.

A "clearing up" change in a repo not in the -Pdev build tries to access a constructor that was mad private in favour of a static method for public use.

@afs
Copy link
Member Author

afs commented Jun 21, 2023

I've added two commits unrelated to the content here but needed to get github actions to run.

The changes are:

  • .mvn/ files - currently empty -- placeholders for the future
  • Set the heap size for jena-jdbc-driver-tdb run of surefire.

Some github actions machines must be quite small. Using my personal account for running the github actions, jena-jdbc-driver-tdb was running out of heap space for tests (specifically TestTdbMemResultSets).

@afs afs merged commit 1615916 into apache:main Jun 22, 2023
@afs afs deleted the guava-alt branch June 22, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace Google Guava with alternative code (caffeine, collections4 and others)

2 participants