Skip to content

GH-1924: Add a "long" Turtle format variant#1923

Closed
rybesh wants to merge 21 commits intoapache:mainfrom
rybesh:main
Closed

GH-1924: Add a "long" Turtle format variant#1923
rybesh wants to merge 21 commits intoapache:mainfrom
rybesh:main

Conversation

@rybesh
Copy link
Contributor

@rybesh rybesh commented Jun 23, 2023

This resolves: #1924

Pull request Description:

Adds a "long" Turtle format variant based on rdflib's "longturtle" format. It uses a fixed indentation width (2) and linebreaks after each sequence element.

See related users@jena ML discussion: https://lists.apache.org/thread/0x2j11zs8vj1pv130hrlqxws4myl908v

I’m not sure how to test this—there do not seem to be any current tests for indentation.


  • Tests are included.
  • Documentation change and updates are provided for the Apache Jena website
  • Commits have been squashed to remove intermediate development commit messages.
  • Key commit messages start with the issue number (GH-xxxx, or if in JIRA, JENA-xxxx)

By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.


See the Apache Jena "Contributing" guide.

@afs
Copy link
Member

afs commented Jun 23, 2023

I've added an issue to track this.

Could you please put "GH-1924: " on the front of the git log message?

@afs
Copy link
Member

afs commented Jun 23, 2023

I’m not sure how to test this—there do not seem to be any current tests for indentation.

The most important testing is round-trip of data: TestRiotWriterGraph and TestTurtleWriter TestTurtleWriterPretty (there are two TestTurtleWriter - I don't know why).

@afs
Copy link
Member

afs commented Jun 23, 2023

@afs afs changed the title Add a "long" Turtle format variant GH-1924: Add a "long" Turtle format variant Jun 24, 2023
@afs
Copy link
Member

afs commented Jun 24, 2023

The enum IndentStyle and class TurtleWriterLong seem to be missing.

@rybesh
Copy link
Contributor Author

rybesh commented Jun 24, 2023

I should be able to add the missing files, docs and tests tomorrow.

@afs
Copy link
Member

afs commented Jun 24, 2023

Great. 4.9.0 is "soon", not "very soon" (having to find time means we can't give accurate dates).

Documentation changes can be after release - we update the site as needed, not just on release.

@rybesh rybesh closed this by deleting the head repository Jun 26, 2023
@rybesh
Copy link
Contributor Author

rybesh commented Jun 26, 2023

Moved to #1925

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support a pretty Turtle format that is long rather than wide.

3 participants

Comments