JENA-2354: Set Caffeine initial cache size to 25% #1996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinow
approved these changes
Aug 25, 2023
Member
kinow
left a comment
kinow
left a comment
There was a problem hiding this comment.
Small change, looks good. I guess you will wait for dobrist's reply in Jira (or merge noe and tweak again later if needed).
Member
Author
|
The OPs best course of action is to control the cache size with StoreParams. Setting the initial cache size isn't safe for databases that are in-use as the cache can grow later on. The initial sizing only delays the pain. It is possible the OP 's setup never filled half the cache in which case the initial setting would over allocate. The size was chosen without a detailed analysis - it seemed like a good idea at the time! There isn't a contract. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue resolved : JENA-2354
Pull request Description:
Set the initial size of the Caffeine cache to 25%, not 50%.
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.