Skip to content

JENA-1270: Deprecate some methods of Capabilities#200

Closed
afs wants to merge 2 commits intoapache:masterfrom
afs:capabilities
Closed

JENA-1270: Deprecate some methods of Capabilities#200
afs wants to merge 2 commits intoapache:masterfrom
afs:capabilities

Conversation

@afs
Copy link
Copy Markdown
Member

@afs afs commented Dec 24, 2016

This PR deprecates the following interface methods and clear up the code to align with these deprecations.

  • addAllowed( everyTriple )
  • deleteAllowed( everyTriple )
  • iteratorRemoveAllowed()
  • canBeEmpty()
  • findContractSafe()

It does not touch handlesLiteralTyping at this stage.

addAllowed( everyTriple )
deleteAllowed( everyTriple )
iteratorRemoveAllowed()
canBeEmpty()
findContractSafe()
@afs
Copy link
Copy Markdown
Member Author

afs commented Dec 24, 2016

If anyone can explain the issue noted in xmloutput/impl/Abbreviated.java, and especially provide a test case if it is still relevant, that would be great.

@ajs6f
Copy link
Copy Markdown
Member

ajs6f commented Dec 24, 2016

👍 to deprecating the whole Capabilities idiom, so 👍 to this.

@ajs6f
Copy link
Copy Markdown
Member

ajs6f commented Dec 25, 2016

All I could find re: 803804 and 858163 was this. Something to do with the old, old confusion between XML Namespaces and RDF prefix management and numerical localnames?

@afs
Copy link
Copy Markdown
Member Author

afs commented Dec 26, 2016

It seems to be something to do with how find behaves if called multiple times with the same arguments as needed by pretty printing in XML. Turtle does not perform an equivalent test. I don't recall that warning message ever being mentioned on users@ so I'm tempted to assume it is no longer relevant.

Copy link
Copy Markdown
Contributor

@Claudenw Claudenw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comment is that there are some lines in GraphContractTest (eg 791) that have capability checks commented out. These are remnants of earlier RDF changes. I think these should be removed as part of this change.

//if (m.getCapabilities().handlesLiteralTyping()) {

@afs afs closed this Jan 1, 2017
@afs afs deleted the capabilities branch January 1, 2017 13:34
@afs
Copy link
Copy Markdown
Member Author

afs commented Jan 1, 2017

Commented capability checks removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants