Preparation work for RIOT RDF/XML parsers#2006
Merged
afs merged 8 commits intoapache:mainfrom Sep 2, 2023
Merged
Conversation
kinow
approved these changes
Sep 2, 2023
| // This disables DTDs entirely for the factory. | ||
| // All DTDs are silently ignored; takes precedence over ACCESS_EXTERNAL_DTD | ||
| // DTDs are silently ignored except for xmlEventReader.nextTag() which throws an exception on a "DTD" event. | ||
| // Code can peek and skip the DTD/ |
|
|
||
| // https://cheatsheetseries.owasp.org/cheatsheets/XML_External_Entity_Prevention_Cheat_Sheet.html#saxbuilder | ||
|
|
||
| // // https://cheatsheetseries.owasp.org/cheatsheets/XML_External_Entity_Prevention_Cheat_Sheet.html#jaxp-documentbuilderfactory-saxparserfactory-and-dom4j |
Member
There was a problem hiding this comment.
Double //'s ? Doesn't really matter though.
| return ; | ||
| } | ||
|
|
||
| // Need to do its just before we append anything, not after a NL, |
Member
Author
|
@kinow -- thank you. Changes made. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is tidy-up and small improvements to internal classes gathered while working on RDF/XML.
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the Contributor's Agreement.